reuvenlax commented on code in PR #24145:
URL: https://github.com/apache/beam/pull/24145#discussion_r1067614274
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiDynamicDestinations.java:
##########
@@ -35,6 +35,8 @@
StorageApiWritePayload toMessage(T element) throws Exception;
+ StorageApiWritePayload toMessage(TableRow tableRow, boolean
respectRequired) throws Exception;
Review Comment:
We can't simply take the unknownFields and convert them to a proto, as there
may be missing required fields (because those fields are in the original
proto). We need a way to do the conversion without enforcing nullability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
