ziqi-ma commented on PR #24911:
URL: https://github.com/apache/beam/pull/24911#issuecomment-1407919491

   > > > > > Hi, once the PR is ready for another review, comment on this with 
`PTAL @<username>`.
   > > > > > Thanks for the starting this.
   > > > > 
   > > > > 
   > > > > PTAL @AnandInguva [I'm still working on the gradle onnxtest (if that 
is the right direction to go), but in the meantime could you let me know how to 
put data at gcp location for integration test? I think maybe that should come 
before the gradle part.]
   > > > 
   > > > 
   > > > Hi, `gs://apache-beam-samples/run_inference` of project 
`apache-beam-testing` should be open to public. You can upload your required 
files/folder here for testing.
   > > 
   > > 
   > > For apache-beam-samples/run_inference, I am able to read but not write, 
getting the error below: User [[[email protected]](mailto:[email protected])] 
does not have permission to access b instance [apache-beam-samples] (or it may 
not exist): [[email protected]](mailto:[email protected]) does not have 
storage.objects.create access to the Google Cloud Storage object. Permission 
'storage.objects.create' denied on resource (or it may not exist).
   > > However, it seems like the other tests use gs://apache-beam-ml/models/ 
and gs://apache-beam-ml/datasets. For these I do not have read access.
   > 
   > Yes that is true. You can share the files with me and I can upload them to 
the GCS bucket for you. You can share them to me at 
[[email protected]](mailto:[email protected])
   
   Hi @AnandInguva - This PR is ready on my end - I added all the gap-related 
tests using my own gcp storage. Could you help copy the files below to the beam 
gcp buckets? (My bucket is open to public)
   
   gs://ziqi-bucket1/torch_2xplus5_onnx   -> 
gs://apache-beam-ml/models/torch_2xplus5_onnx
   gs://ziqi-bucket1/tf_2xplus5_onnx          -> 
gs://apache-beam-ml/models/tf_2xplus5_onnx
   gs://ziqi-bucket1/skl_2xplus5_onnx        -> 
gs://apache-beam-ml/models/skl_2xplus5_onnx
   
   gs://ziqi-bucket1/sentiment_classification_input.txt   -> 
gs://apache-beam-ml/testing/inputs/onnx/sentiment_classification_input.txt
   gs://ziqi-bucket1/roberta_sentiment_classification.onnx  -> 
gs://apache-beam-ml/models/roberta_sentiment_classification.onnx
   gs://ziqi-bucket1/sentiment_classification_expected_output.txt -> 
gs://apache-beam-ml/testing/expected_outputs/test_onnx_run_inference_roberta_sentiment_classification_actuals.txt
   
   Thanks!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to