ziqi-ma commented on PR #24911: URL: https://github.com/apache/beam/pull/24911#issuecomment-1416686395
> Most of this looks good to me. > > I would clean up the lint, formatting errors for the checks to go green and we can start finalizing the PR. Hi -thanks. I fixed the formatting errors but seems like the 2 remaining failures are about files/tests that should not be touched by this PR? - codecov/patch is complaining 0.00% diff hit (and it seems to be one line not covered in sdks/python/apache_beam/runners/worker/bundle_processor.py? (I'm not sure how to cover it?) - py310 test is failing due to a segfault, but I only added onnx tests for py38? Would be great if you could give some pointers regarding these, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
