saavannanavati commented on a change in pull request #12009:
URL: https://github.com/apache/beam/pull/12009#discussion_r455230574



##########
File path: website/www/site/content/en/documentation/sdks/python-type-safety.md
##########
@@ -90,6 +91,15 @@ The following code declares an `int` input and a `str` 
output type hint on the `
 {{< code_sample 
"sdks/python/apache_beam/examples/snippets/snippets_test_py3.py" 
type_hints_map_annotations >}}
 {{< /highlight >}}
 
+The following code demonstrates how to use annotations on `PTransform` 
subclasses. 
+A valid annotation is a `PCollection`, `PBegin`, or `PDone` that wraps an 
internal (nested) type. 

Review comment:
       Sounds good. 
   
   Should we update documentation 
[here](https://beam.apache.org/documentation/programming-guide/) and 
[here](https://beam.apache.org/documentation/sdks/python-type-safety/) to note 
the existence of `PBegin`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to