saavannanavati commented on a change in pull request #12009:
URL: https://github.com/apache/beam/pull/12009#discussion_r456109961
##########
File path: website/www/site/content/en/documentation/sdks/python-type-safety.md
##########
@@ -90,6 +91,15 @@ The following code declares an `int` input and a `str`
output type hint on the `
{{< code_sample
"sdks/python/apache_beam/examples/snippets/snippets_test_py3.py"
type_hints_map_annotations >}}
{{< /highlight >}}
+The following code demonstrates how to use annotations on `PTransform`
subclasses.
+A valid annotation is a `PCollection`, `PBegin`, or `PDone` that wraps an
internal (nested) type.
Review comment:
Sounds good
> The python-type-safety update in this PR already mentions PBegin. Did you
want to add more details?
It also mentions PDone, do we want to remove that?
> I would like to split the programming guide update into a separate PR,
since it will include examples from multiple languages and possibly some more
discussion. This will be tracked in
[BEAM-10495](https://issues.apache.org/jira/browse/BEAM-10495), and you can
take it on if you wish.
I'll focus on benchmarking the runtime type checking system for now but if
time permits afterwards, sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
