Abacn commented on code in PR #25056:
URL: https://github.com/apache/beam/pull/25056#discussion_r1100880375
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java:
##########
@@ -260,15 +266,12 @@ public static class Read extends
PTransform<PCollection<String>, Read.Result> {
public Read() {}
- public static class Result implements POutput, PInput {
-
- private PCollection<HL7v2Message> messages;
-
- private PCollection<HealthcareIOError<String>> failedReads;
- PCollectionTuple pct;
+ public static class Result extends HL7v2ReadResult<String, HL7v2Message> {
Review Comment:
ideally each public class (that would be rendered to javadoc) should have
docstring. Would you mind add a brief docstring also here?
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IOTest.java:
##########
@@ -59,6 +61,30 @@ public void test_HL7v2IO_failedReads() {
pipeline.run();
}
+ @Test
+ public void test_HL7v2IO_failedReadsByParameter() {
Review Comment:
```suggestion
public void testHL7v2IOFailedReadsByParameter() {
```
We use smallCamelNamingStyle in Java
This leads to me to wonder if our checkStyle for test code no longer working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
