hnnsgstfssn commented on PR #25808: URL: https://github.com/apache/beam/pull/25808#issuecomment-1464941382
> For the drain issue, Python and Java implementation also did not drain until recent fix (#23765 #25716). Basically the transform should (i) update watermark when advance and (ii) truncate immediately when truncate is called (happens in drain) Ah! I didn't realize those fixes [1][2] for Python were recent- thanks for highlight it. I tried including both (i) and (ii) here i.e. implementing `TruncateRestriction` and `CreateWatermarkEstimator` and updating the watermark in `ProcessElement`, but might not be doing it correctly. [1] https://github.com/apache/beam/commit/30b26171b4038c1c976adbc3be386e118b35153b [2] https://github.com/apache/beam/commit/7dba78d611089a1826c5655ed7ffcdf3f6007eae -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
