AnandInguva commented on code in PR #25785:
URL: https://github.com/apache/beam/pull/25785#discussion_r1136267236
##########
sdks/python/gen_protos.py:
##########
@@ -311,12 +311,6 @@ def ensure_grpcio_exists():
try:
from grpc_tools import protoc # pylint: disable=unused-import
except ImportError:
- if platform.system() == 'Windows':
Review Comment:
Tox is following the build-system
https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#build-system-requirement
as per PEP 517. Since setup.py doesn't follow/have `build-system` where we
could install build requirements to build sdist package, we need to install the
build-requirements.txt during runtime. so we need to do that for windows, macOS
and ubuntu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
