damccorm commented on code in PR #25785:
URL: https://github.com/apache/beam/pull/25785#discussion_r1137703779


##########
sdks/python/tox.ini:
##########
@@ -64,8 +64,9 @@ commands = false {envname} is misconfigured
 
 [testenv:py{37,38,39,310}]
 commands =
+  pip install -r build-requirements.txt

Review Comment:
   > sdist is getting build in a different environment compared to the deps
   
   Ah, gotcha - thanks.
   
   > I can remove that step and see if this works as expected.
   
   I'd prefer we try that. I still don't quite get why this is necessary only 
for this test-env



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to