chamikaramj commented on code in PR #25824:
URL: https://github.com/apache/beam/pull/25824#discussion_r1173116159
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java:
##########
@@ -630,6 +652,11 @@ && getConnectionInitSqls().get() != null
if (getDriverClassLoader() != null) {
basicDataSource.setDriverClassLoader(getDriverClassLoader());
}
+ if (getDriverJars() != null) {
+ URLClassLoader classLoader =
Review Comment:
Java dependencies are usually added via the filesToStage option [1] (which
defaults to everything in CLASSPATH). Just specifying a jar here does not
result in the jar being available to workers. So users will also need to make
sure the add these jars to the filesToStage option or the CLASSPATH in-addition
to providing here. Is that correct ?
[1]
https://github.com/apache/beam/blob/7134cfdd9daffa649c5401c79cc321732302c53b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/FileStagingOptions.java#L36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
