lostluck commented on code in PR #26882:
URL: https://github.com/apache/beam/pull/26882#discussion_r1210531827
##########
sdks/go/test/integration/primitives/checkpointing_test.go:
##########
@@ -18,15 +18,11 @@ package primitives
import (
"testing"
- "github.com/apache/beam/sdks/v2/go/pkg/beam"
"github.com/apache/beam/sdks/v2/go/pkg/beam/testing/ptest"
"github.com/apache/beam/sdks/v2/go/test/integration"
)
func TestCheckpointing(t *testing.T) {
integration.CheckFilters(t)
-
- p, s := beam.NewPipelineWithRoot()
- Checkpoints(s)
- ptest.RunAndValidate(t, p)
+ ptest.BuildAndRun(t, Checkpoints)
Review Comment:
I've been leaning this way for a long time too, and it will mesh nicely with
a proper options per-pipeline specifier, rather than *everything is flags*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
