TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r462956031
##########
File path: release/src/main/scripts/download_github_actions_artifacts.py
##########
@@ -170,7 +170,7 @@ def get_last_run_id(
f"GCS location corresponding to artifacts built in this run: "
f"gs://beam-wheels-staging/{release_branch}/{release_commit}-{last_run_id}/"
)
- return safe_get(last_run, "id")
+ return last_run_id
Review comment:
> My concerns are mostly around quota. If actions quota is not a
concern, then it's fine.
I suppose quota for actions should not be a problem
([docs](https://docs.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits)).
AFAIK apache has Enteprise plan.
> If it is easy to configure, i would skip "Upload to GCS" steps for merges
to master.
Why would you like to skip it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
