TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r460396860
##########
File path: release/src/main/scripts/download_github_actions_artifacts.py
##########
@@ -170,7 +170,7 @@ def get_last_run_id(
f"GCS location corresponding to artifacts built in this run: "
f"gs://beam-wheels-staging/{release_branch}/{release_commit}-{last_run_id}/"
)
- return safe_get(last_run, "id")
+ return last_run_id
Review comment:
Here is some related discussion from previous PR which introduces
gh-actions:
https://github.com/apache/beam/pull/11877#issuecomment-641886596
The idea of building source dist / wheels was that it could be a good check
for python related changes on PR (path filtering). I can imagine that some
change could slip in which would cause problems with building wheels later on.
Check on push to master and schedule also helps to find some potential bugs.
Scheduled run on master was inspired by Apache Airflow workflow:
https://github.com/apache/airflow/blob/master/.github/workflows/ci.yml#L503
What do you think about this approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
