ahmedabu98 commented on PR #26889: URL: https://github.com/apache/beam/pull/26889#issuecomment-1593638937
Hey, sorry for the delay, I was on vacation for a while. Would it be feasible to create a new `model_bigqueryio` for Storage API write method? Then we can add a new test (also just for Storage API) that we can trigger with the rest of the GCP xlang tests. We can add a few decorators to the new test to make sure it runs on the GCP xlang postcommits and get skipped otherwise, e.g.: https://github.com/apache/beam/blob/644f5399dce646ba9b6b0146b44ff7778fc0a8c1/sdks/python/apache_beam/io/external/xlang_bigqueryio_it_test.py#L53-L56 This means it won't run with the Python Coverage Commit tests, but will run on `PostCommit_Python_Xlang_Gcp_Direct` and `PostCommit_Python_Xlang_Gcp_Dataflow` Let me know what you think of this suggestion :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
