reuvenlax commented on PR #26320: URL: https://github.com/apache/beam/pull/26320#issuecomment-1599216766
Can we test to see whether this breaks update compatibility for Dataflow? A lot of jobs use AvroCoder, so we should not be breaking compatibility here unless there is a very strong reason. On Tue, Jun 20, 2023 at 12:30 AM Michel Davit ***@***.***> wrote: > I know the issue: > The Conversions.DecimalConversion must be removed from the ReflectData > used in the ReflectDatumFactory. > This conversions implies to have scale and precision set in the schema, > which can't be inferred by reflection. > ReflectData <https://avro.apache.org/docs/1.11.1/api/java/> by default > supports BigDecimal, converting it to String with the java-class property: > > {"type": "string", "java-class": "java.math.BigDecimal"} > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/26320#issuecomment-1598263156>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAYJVKNSIKFARRSZI4YNCDXMFGQ3ANCNFSM6AAAAAAXCM4H3A> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
