George-Wu commented on a change in pull request #12331: URL: https://github.com/apache/beam/pull/12331#discussion_r464632452
########## File path: sdks/python/apache_beam/io/gcp/dicomio.py ########## @@ -0,0 +1,572 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""DICOM IO connector +This module implements several tools to facilitate the interaction between +a Google Cloud Healthcare DICOM store and a Beam pipeline. +For more details on DICOM store and API: +https://cloud.google.com/healthcare/docs/how-tos/dicom +The DICOM IO connector can be used to search metadata or write DICOM files +to DICOM store. When used together with Google Pubsub message connector, +a PTransform implemented in this module can be used to convert pubsub +messages to search requests. Since Traceability is crucial for healthcare +API users, every input or error message will be recorded in the output of +the DICOM IO connector. As a result, every PTransform in this module will +return a PCollection of dict that encodes results and detailed error messages. Review comment: You are right, although most of the time it's used together with pubsub, the string can come from any source. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
