George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r463411782



##########
File path: sdks/python/setup.py
##########
@@ -128,6 +128,7 @@ def get_version():
   cythonize = lambda *args, **kwargs: []
 
 REQUIRED_PACKAGES = [
+    'google-auth>=1.18.0,<=1.20.0',

Review comment:
       For some reason if I put it under GCP_REQUIREMENTS, there will still be 
'no mudule found
   errors caused by google.auth during the unittest. 
https://ci-beam.apache.org/job/beam_PreCommit_Python_Commit/14212/testReport/junit/(root)/(empty)/apache_beam_io_gcp_dicomio_test_7/

##########
File path: sdks/python/setup.py
##########
@@ -128,6 +128,7 @@ def get_version():
   cythonize = lambda *args, **kwargs: []
 
 REQUIRED_PACKAGES = [
+    'google-auth>=1.18.0,<=1.20.0',

Review comment:
       For some reason if I put it under GCP_REQUIREMENTS, there will be 'no 
mudule found
   errors caused by google.auth during the unittest. 
https://ci-beam.apache.org/job/beam_PreCommit_Python_Commit/14212/testReport/junit/(root)/(empty)/apache_beam_io_gcp_dicomio_test_7/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to