tvalentyn commented on PR #27436: URL: https://github.com/apache/beam/pull/27436#issuecomment-1656470773
Thanks, changes look good to me. have you tested them in positive and negative case? Negative case requries building a custom docker image similar to https://cloud.google.com/dataflow/docs/guides/using-custom-containers#use_a_custom_base_image_or_multi-stage_builds but w/o Beam. If you are already OOO i can TAL next week, np. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
