Abacn commented on code in PR #28969:
URL: https://github.com/apache/beam/pull/28969#discussion_r1357381947


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -179,6 +179,16 @@ class BeamModulePlugin implements Plugin<Project> {
      * The set of additional maven repositories that should be added into 
published POM file.
      */
     List<Map> mavenRepositories = []
+
+    /**
+     * Flag to compile the main source with testJavaVersion project property 
(if set).
+     *
+     * Set this configuration if the project sources are supposed to be 
compiled in given Java version
+     * for testing propose (e.g. pipeline Examples).
+     *
+     * <p>If testJavaVersion project property is not set (e.g. publish 
artifacts), it should has no effect.
+     */
+    boolean compileWithTestJavaVersion = false

Review Comment:
   We need a configuration for plugin instead of project property because this 
is project (e.g. `:examples:java`) specific. During a build only test fixture 
project should be compiled with testJavaVersion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to