Abacn commented on code in PR #28969:
URL: https://github.com/apache/beam/pull/28969#discussion_r1357382461
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1078,6 +1115,16 @@ class BeamModulePlugin implements Plugin<Project> {
runtimeOnly.extendsFrom(provided)
}
+ // overwrite javaVersion if compileWithTestJavaVersion is set
+ if (configuration.compileWithTestJavaVersion &&
project.hasProperty("testJavaVersion")) {
+ def ver = project.getProperty('testJavaVersion')
+ if (ver == '8') {
+ project.javaVersion = '1.8'
+ } else {
+ project.javaVersion = ver
Review Comment:
javaVersion string has changed since Java9 as such
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
