pranavbhandari24 commented on code in PR #28825:
URL: https://github.com/apache/beam/pull/28825#discussion_r1360751511
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/CoderProviders.java:
##########
@@ -178,7 +178,9 @@ public CoderProviderForCoder(TypeDescriptor<?> type,
Coder<?> coder) {
@Override
public <T> Coder<T> coderFor(TypeDescriptor<T> type, List<? extends
Coder<?>> componentCoders)
throws CannotProvideCoderException {
- if (!this.type.equals(type)) {
+ if (!(this.type.equals(type)
+ || (type.getRawType().getName().contains("AutoValue_")
+ && this.type.getRawType().isAssignableFrom(type.getRawType()))))
{
Review Comment:
Done
##########
sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkEventWriter.java:
##########
@@ -426,6 +451,25 @@ public static byte[] getCertFromGcsAsBytes(String
filePath) throws IOException {
}
}
+ private static boolean isValidUrlFormat(String url) {
Review Comment:
Added unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
