Abacn commented on code in PR #29009:
URL: https://github.com/apache/beam/pull/29009#discussion_r1360918893
##########
.github/workflows/beam_PostCommit_Java_ValidatesRunner_Flink.yml:
##########
@@ -86,6 +86,7 @@ jobs:
uses: EnricoMi/publish-unit-test-result-action@v2
if: always()
with:
+ large_files: true
Review Comment:
thanks for fixing this!
##########
.github/workflows/beam_PostCommit_Python_Examples_Flink.yml:
##########
@@ -53,7 +53,7 @@ jobs:
github.event_name == 'workflow_dispatch' ||
startsWith(github.event.comment.body, 'Run Python Examples_Flink')
runs-on: [self-hosted, ubuntu-20.04, main]
- timeout-minutes: 120
+ timeout-minutes: 240
Review Comment:
if it takes so long might due to some other issue, the same test on Jenkins
takes short time to finish:
https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Python_Examples_Flink/buildTimeTrend
##########
.github/workflows/beam_PostCommit_Java_ValidatesRunner_Direct.yml:
##########
@@ -75,9 +75,7 @@ jobs:
distribution: 'zulu'
java-version: '8'
- name: run validatesRunner script
- uses: ./.github/actions/gradle-command-self-hosted-action
- with:
- gradle-command: :runners:direct-java:validatesRunner
+ run: ./gradlew :runners:direct-java:validatesRunner
Review Comment:
These changes from using composite action to a command line directly. What
was the problem for gradle-command-self-hosted-action here, should we focus on
fix the action instead?
If it is some default options in `gradle-command-self-hosted-action`, should
we have an option to control those options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
