andreydevyatkin commented on code in PR #29009:
URL: https://github.com/apache/beam/pull/29009#discussion_r1361105507
##########
.github/workflows/beam_PostCommit_Java_ValidatesRunner_Direct.yml:
##########
@@ -75,9 +75,7 @@ jobs:
distribution: 'zulu'
java-version: '8'
- name: run validatesRunner script
- uses: ./.github/actions/gradle-command-self-hosted-action
- with:
- gradle-command: :runners:direct-java:validatesRunner
+ run: ./gradlew :runners:direct-java:validatesRunner
Review Comment:
Yes, I noticed that the Jenkins job doesn't use the default arguments like
`-Pdocker-pull-licenses`. As an alternative way we can specify the
`default-arguments` as empty:
```
- name: run validatesRunner script
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :runners:direct-java:validatesRunner
default-arguments: ''
```
But there is a `max-workers` argument that should also be handled somehow.
So, I found running it as a command line easier than changing action and adding
additional validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
