Polber commented on code in PR #28971:
URL: https://github.com/apache/beam/pull/28971#discussion_r1367245057
##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
@@ -112,3 +112,38 @@
'WriteToJson': 'beam:schematransform:org.apache.beam:json_write:v1'
config:
gradle_target: 'sdks:java:extensions:schemaio-expansion-service:shadowJar'
+
+- type: renaming
+ transforms:
+ 'ReadFromJdbc': 'ReadFromJdbc'
+ 'WriteToJdbc': 'WriteToJdbc'
+ config:
+ mappings:
+ 'ReadFromJdbc':
+ driver_class_name: 'driverClassName'
+ jdbc_url: 'jdbcUrl'
+ username: 'username'
+ password: 'password'
Review Comment:
That's how the transform works today, but I can add a FR for KMS/Secret
Manager support. Unless you think it's not worth offering without that support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
