Polber commented on code in PR #28971:
URL: https://github.com/apache/beam/pull/28971#discussion_r1372104488
##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
@@ -112,3 +112,38 @@
'WriteToJson': 'beam:schematransform:org.apache.beam:json_write:v1'
config:
gradle_target: 'sdks:java:extensions:schemaio-expansion-service:shadowJar'
+
+- type: renaming
+ transforms:
+ 'ReadFromJdbc': 'ReadFromJdbc'
+ 'WriteToJdbc': 'WriteToJdbc'
+ config:
+ mappings:
+ 'ReadFromJdbc':
+ driver_class_name: 'driverClassName'
+ jdbc_url: 'jdbcUrl'
+ username: 'username'
+ password: 'password'
+ table_name: 'location'
+ read_query: 'readQuery'
+ num_rows: 'fetchSize'
+ driver_jars: 'driverJars'
+ connection_properties: 'connectionProperties'
+ connection_init_sql: 'connectionInitSql'
+ 'WriteToJdbc':
+ driver_class_name: 'driverClassName'
+ jdbc_url: 'jdbcUrl'
+ username: 'username'
+ password: 'password'
+ table_name: 'location'
+ write_statement: 'writeStatement'
Review Comment:
Would this possibly introduce a security risk exposing the column names
directly in the query? I know we use the prepared statement for the values to
protect against SQL injection since the values could possibly come from an
unverified source. I think this is prevented for the column names since they
are set in the row schema when the pipeline is written, so it should be safe,
but do you think there could be a way to break this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
