brucearctor commented on code in PR #28865:
URL: https://github.com/apache/beam/pull/28865#discussion_r1370960859
##########
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaReadSchemaTransformProviderTest.java:
##########
@@ -120,7 +120,6 @@ public void testBuildTransformWithAvroSchema() {
KafkaReadSchemaTransformConfiguration.builder()
.setTopic("anytopic")
.setBootstrapServers("anybootstrap")
- .setFormat("avro")
.setSchema(AVRO_SCHEMA)
Review Comment:
is .setSchema sufficient [ if AVRO_SCHEMA ], that we don't need AVRO in
setFormat? [ I probably need to read this class to see if this gets auto set ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
