brucearctor commented on code in PR #28865:
URL: https://github.com/apache/beam/pull/28865#discussion_r1374016641


##########
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaReadSchemaTransformProviderTest.java:
##########
@@ -120,7 +120,6 @@ public void testBuildTransformWithAvroSchema() {
         KafkaReadSchemaTransformConfiguration.builder()
             .setTopic("anytopic")
             .setBootstrapServers("anybootstrap")
-            .setFormat("avro")
             .setSchema(AVRO_SCHEMA)

Review Comment:
   I don't fully understand this ...  since the diff of the PR shows removing 
the line.  BUT, since tests aren't failing, I guess this isn't causing a 
problem.  Would like to add even more test cases, BUT, I don't think required 
or needed to hold things up.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to