volatilemolotov commented on code in PR #29194:
URL: https://github.com/apache/beam/pull/29194#discussion_r1377743275
##########
.github/workflows/beam_Release_NightlySnapshot.yml:
##########
@@ -50,9 +50,8 @@ jobs:
job_name: [beam_Release_NightlySnapshot]
job_phrase: [Release Nightly Snapshot]
if: |
- (github.event_name == 'workflow_dispatch' ||
- github.event_name == 'schedule') &&
- github.repository == 'apache/beam'
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'schedule'
Review Comment:
For SDK, Nightly and Python nightly, it was my mistake, ill fix it.
For docker its
```
github.event_name == 'workflow_dispatch' ||
(github.event_name == 'schedule' && github.repository ==
'apache/beam') ||
github.event.comment.body == 'Publish Docker Snapshots'
```
Is this ok? My logic is to combine the schedule and repo and not affect
workflow dispatch and comment body as those would require significant effort to
run within the project and it would be easier to just remove if in fork at that
point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
