Abacn commented on code in PR #29194:
URL: https://github.com/apache/beam/pull/29194#discussion_r1377798568
##########
.github/workflows/beam_Release_NightlySnapshot.yml:
##########
@@ -50,9 +50,8 @@ jobs:
job_name: [beam_Release_NightlySnapshot]
job_phrase: [Release Nightly Snapshot]
if: |
- (github.event_name == 'workflow_dispatch' ||
- github.event_name == 'schedule') &&
- github.repository == 'apache/beam'
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'schedule'
Review Comment:
Sorry, beam_Publish_Docker_Snapshots is good
##########
.github/workflows/beam_Release_NightlySnapshot.yml:
##########
@@ -50,9 +50,8 @@ jobs:
job_name: [beam_Release_NightlySnapshot]
job_phrase: [Release Nightly Snapshot]
if: |
- (github.event_name == 'workflow_dispatch' ||
- github.event_name == 'schedule') &&
- github.repository == 'apache/beam'
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'schedule'
Review Comment:
Can we revert changes on the publish snapshot tasks? They already had the
condition of repository. Previously it was added because snapshots were
published from forks that had sha not belong to master caused internal import
failures
these workflows
- .github/workflows/beam_Publish_Beam_SDK_Snapshots.yml
~- .github/workflows/beam_Publish_Docker_Snapshots.yml~
- .github/workflows/beam_Release_NightlySnapshot.yml
- .github/workflows/beam_Release_Python_NightlySnapshot.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
