tomstepp commented on code in PR #29395:
URL: https://github.com/apache/beam/pull/29395#discussion_r1391776862
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubSubPayloadTranslation.java:
##########
@@ -59,6 +60,10 @@ public String getUrn() {
@Override
public RunnerApi.FunctionSpec translate(
AppliedPTransform<?, ?, Unbounded<?>> transform, SdkComponents
components) {
+ if (ExperimentalOptions.hasExperiment(
Review Comment:
Looks like replaceV1Transforms is only used for v1. The portable job
submission proto is created ahead of this at line 1170 for v2 jobs. Is it a
suitable+better fix to run replaceV1Transforms before creating
portablePipelineProto?
Or if replaceV1Transforms has some things that are meant to be only for v1,
then perhaps we can split out the custom pubsub overrides to occur before the
portable job submission proto is created, and leave the remaining overrides to
be done only for v1 pipeline.
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubSubPayloadTranslation.java:
##########
@@ -59,6 +60,10 @@ public String getUrn() {
@Override
public RunnerApi.FunctionSpec translate(
AppliedPTransform<?, ?, Unbounded<?>> transform, SdkComponents
components) {
+ if (ExperimentalOptions.hasExperiment(
Review Comment:
Looks like replaceV1Transforms is only used for v1. The portable job
submission proto is created ahead of this at line 1170 for v2 jobs. Is it a
suitable+better fix to run replaceV1Transforms before creating
portablePipelineProto?
Or if replaceV1Transforms has some things that are meant to be only for v1,
then perhaps we can split out the custom pubsub overrides to occur before the
portable job submission proto is created, and leave the remaining overrides to
be done only for v1 pipelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
