Abacn commented on code in PR #29395:
URL: https://github.com/apache/beam/pull/29395#discussion_r1393070692
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubSubPayloadTranslation.java:
##########
@@ -59,6 +60,10 @@ public String getUrn() {
@Override
public RunnerApi.FunctionSpec translate(
AppliedPTransform<?, ?, Unbounded<?>> transform, SdkComponents
components) {
+ if (ExperimentalOptions.hasExperiment(
Review Comment:
Thanks for explanation, I see. Both V1 and V2 pipeline protos are
constructed in DataflowRunner.run()
- V2 pipeline proto is `portablePipelineProto`, used to write to
stagedPipeline
- V1 pipeline proto is `dataflowV1PipelineProto`, used to construct
jobSpecification and essentially initiate the job (newJob)
This is unusual and quite easily get confused at first glance... but
anywhere here we are. I understand now why the DataflowRunner settings won't
affect runner v2 job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
