Abacn commented on code in PR #29557:
URL: https://github.com/apache/beam/pull/29557#discussion_r1409613355
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/CreateStreamingFlinkView.java:
##########
@@ -49,9 +56,20 @@ public CreateStreamingFlinkView(PCollectionView<ViewT> view)
{
@Override
public PCollection<ElemT> expand(PCollection<ElemT> input) {
- input
- .apply(Combine.globally(new Concatenate<ElemT>()).withoutDefaults())
- .apply(CreateFlinkPCollectionView.of(view));
+ PCollection<List<ElemT>> iterable;
+ // See https://github.com/apache/beam/pull/25940
+ if (view.getViewFn() instanceof PCollectionViews.IsSingletonView) {
+ TypeDescriptor<ElemT> inputType = input.getTypeDescriptor();
+ Preconditions.checkStateNotNull(inputType);
Review Comment:
```suggestion
TypeDescriptor<ElemT> inputType =
Preconditions.checkStateNotNull(input.getTypeDescriptor());
```
nit: this makes nullable check happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
