jto commented on PR #29557: URL: https://github.com/apache/beam/pull/29557#issuecomment-1832431978
I shamelessly copied the implementation from the DirectRunner: https://github.com/apache/beam/blob/f68420490644139cc018439a7ef8455069f8b3de/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectWriteViewVisitor.java#L94-L100. The DataflowRunner also does something very similar: https://github.com/apache/beam/blob/f68420490644139cc018439a7ef8455069f8b3de/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/StreamingViewOverrides.java#L70-L84 There's an explanation of how that works in the DF fix: https://github.com/apache/beam/pull/25940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
