edman124 commented on code in PR #29879:
URL: https://github.com/apache/beam/pull/29879#discussion_r1449435290
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -587,6 +588,13 @@ public void start() {
options.getWindmillHarnessUpdateReportingPeriod().getMillis(),
TimeUnit.MILLISECONDS);
+ workerMessageReportTimer = executorSupplier.apply("WorkerMessageTimer");
+ workerMessageReportTimer.scheduleWithFixedDelay(
+ this::reportPeriodicWorkerMessage,
+ 0,
+ options.getWindmillHarnessUpdateReportingPeriod().getMillis(),
Review Comment:
A little confused on the part about not scheduling with fixed delay, the
other scheduling option is with fixed period since we need the metrics to be
sent every so often like the counter metrics being sent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
