edman124 commented on code in PR #29879:
URL: https://github.com/apache/beam/pull/29879#discussion_r1449489154


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -587,6 +588,13 @@ public void start() {
         options.getWindmillHarnessUpdateReportingPeriod().getMillis(),
         TimeUnit.MILLISECONDS);
 
+    workerMessageReportTimer = executorSupplier.apply("WorkerMessageTimer");
+    workerMessageReportTimer.scheduleWithFixedDelay(
+        this::reportPeriodicWorkerMessage,
+        0,
+        options.getWindmillHarnessUpdateReportingPeriod().getMillis(),

Review Comment:
   updated to add check before scheduling, but still using schedule with fixed 
delay, which seems to be working without any problems



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to