ahmedabu98 commented on code in PR #31323:
URL: https://github.com/apache/beam/pull/31323#discussion_r1605667268
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiDynamicDestinationsBeamRow.java:
##########
@@ -86,11 +86,11 @@ public DescriptorProtos.DescriptorProto
getDescriptor(boolean includeCdcColumns)
public StorageApiWritePayload toMessage(
T element, @Nullable RowMutationInformation rowMutationInformation)
throws Exception {
String changeType = null;
- long changeSequenceNum = -1;
+ String changeSequenceNum = null;
Review Comment:
if `rowMutationInformation` is null (as it is in most use-cases), what
change sequence value do we set in the DynamicMessage? Can we set a null value?
(Similarly for the changes in Avro and TableRow paths)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
