m-trieu commented on code in PR #31317:
URL: https://github.com/apache/beam/pull/31317#discussion_r1610676358
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/StreamingEngineClient.java:
##########
@@ -164,23 +177,27 @@ public static StreamingEngineClient create(
JobHeader jobHeader,
GetWorkBudget totalGetWorkBudget,
GrpcWindmillStreamFactory streamingEngineStreamFactory,
- WorkItemProcessor processWorkItem,
+ WorkItemScheduler processWorkItem,
ChannelCachingStubFactory channelCachingStubFactory,
GetWorkBudgetDistributor getWorkBudgetDistributor,
- GrpcDispatcherClient dispatcherClient) {
- StreamingEngineClient streamingEngineClient =
- new StreamingEngineClient(
- jobHeader,
- totalGetWorkBudget,
- new AtomicReference<>(StreamingEngineConnectionState.EMPTY),
- streamingEngineStreamFactory,
- processWorkItem,
- channelCachingStubFactory,
- getWorkBudgetDistributor,
- dispatcherClient,
- new Random().nextLong());
- streamingEngineClient.start();
- return streamingEngineClient;
+ GrpcDispatcherClient dispatcherClient,
+ Function<WindmillStream.CommitWorkStream, WorkCommitter>
workCommitterFactory,
+ Consumer<List<Windmill.ComputationHeartbeatResponse>> heartbeatProcessor,
+ AtomicReference<StreamingEngineConnectionState>
streamingEngineConnectionsState) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
