m-trieu commented on code in PR #31317:
URL: https://github.com/apache/beam/pull/31317#discussion_r1613958837
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java:
##########
@@ -151,37 +154,22 @@ public boolean workIsFailed() {
public void start(
@Nullable Object key,
- Windmill.WorkItem work,
- Instant inputDataWatermark,
- @Nullable Instant outputDataWatermark,
- @Nullable Instant synchronizedProcessingTime,
+ Work work,
WindmillStateReader stateReader,
SideInputStateFetcher sideInputStateFetcher,
- Windmill.WorkItemCommitRequest.Builder outputBuilder,
- @Nullable Supplier<Boolean> workFailed) {
+ Windmill.WorkItemCommitRequest.Builder outputBuilder) {
this.key = key;
- this.work = work;
- this.workIsFailed = (workFailed != null) ? workFailed : () ->
Boolean.FALSE;
+ this.work = work.getWorkItem();
+ this.workIsFailed = work::isFailed;
this.computationKey =
- WindmillComputationKey.create(computationId, work.getKey(),
work.getShardingKey());
+ WindmillComputationKey.create(
+ computationId, work.getWorkItem().getKey(),
work.getWorkItem().getShardingKey());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
