lostluck commented on code in PR #31420:
URL: https://github.com/apache/beam/pull/31420#discussion_r1617670484
##########
sdks/go/pkg/beam/core/runtime/exec/datasource.go:
##########
@@ -151,6 +159,7 @@ func (n *DataSource) process(ctx context.Context, data
func(bcr *byteCountReader
// io.EOF means the reader successfully drained.
// We're ready for a new buffer.
case <-ctx.Done():
+ n.waitingForRunnerToSendData.Store(true)
Review Comment:
Did this need to be set to allow for clean runner side shutdown? If so, it
might be good to have a comment to that effect. Otherwise, technically at this
point the SDK is *explicitly* not waiting for data, it's shutting down.
This line only executes in the rare case where the context is canceled,
which largely would only happen when running in a Loopback execution mode, eg
for tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
