priyansndesai commented on code in PR #31420:
URL: https://github.com/apache/beam/pull/31420#discussion_r1619069221
##########
sdks/python/apache_beam/runners/worker/bundle_processor.py:
##########
@@ -123,16 +123,17 @@
class RunnerIOOperation(operations.Operation):
"""Common baseclass for runner harness IO operations."""
- def __init__(self,
- name_context, # type: common.NameContext
- step_name, # type: Any
- consumers, # type: Mapping[Any, Iterable[operations.Operation]]
- counter_factory, # type: counters.CounterFactory
- state_sampler, # type: statesampler.StateSampler
- windowed_coder, # type: coders.Coder
- transform_id, # type: str
- data_channel # type: data_plane.DataChannel
- ):
+ def __init__(
Review Comment:
Done. Thanks!
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataInboundObserver.java:
##########
@@ -119,7 +127,12 @@ public void close() throws Exception {
public void awaitCompletion() throws Exception {
try {
while (true) {
+ // The SDK is available to process data right before it is ready to
take elements off the
Review Comment:
Clarified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
