robertwb commented on a change in pull request #12682:
URL: https://github.com/apache/beam/pull/12682#discussion_r476699247
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -348,6 +358,8 @@ def aggregate(self, func, axis=0, *args, **kwargs):
'order-sensitive')
diff = frame_base.wont_implement_method('order-sensitive')
+ drop = frame_base._elementwise_method('drop')
Review comment:
drop has a lot of arguments, not all of them work with elementwise.
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -213,7 +213,14 @@ def update(self, other):
DeferredSeries,
'__i%s__' % base,
frame_base._elementwise_method('__i%s__' % base, inplace=True))
-for name in ['__lt__', '__le__', '__gt__', '__ge__', '__eq__', '__ne__']:
+for name in ['__lt__',
+ '__le__',
+ '__gt__',
+ '__ge__',
+ '__eq__',
+ '__ne__',
+ '__or__',
Review comment:
Add `__ior__` and `__iand__` as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
