TheNeuralBit commented on a change in pull request #12682:
URL: https://github.com/apache/beam/pull/12682#discussion_r476707154
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -348,6 +358,8 @@ def aggregate(self, func, axis=0, *args, **kwargs):
'order-sensitive')
diff = frame_base.wont_implement_method('order-sensitive')
+ drop = frame_base._elementwise_method('drop')
Review comment:
Ok we can just drop that commit for now. I'm not actually using drop in
the demo since `__getitem__` is cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]