m-trieu commented on code in PR #31784:
URL: https://github.com/apache/beam/pull/31784#discussion_r1691565940
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/WindmillStream.java:
##########
@@ -32,15 +33,37 @@
/** Superclass for streams returned by streaming Windmill methods. */
@ThreadSafe
public interface WindmillStream {
+
+ /** An identifier for the backend worker where the stream is
sending/receiving RPCs. */
+ String backendWorkerToken();
+
/** Indicates that no more requests will be sent. */
- void close();
+ void halfClose();
/** Waits for the server to close its end of the connection, with timeout. */
boolean awaitTermination(int time, TimeUnit unit) throws
InterruptedException;
/** Returns when the stream was opened. */
Instant startTime();
+ /**
+ * Shutdown the stream. There should be no further interactions with the
stream once this has been
+ * called.
+ */
+ void shutdown();
+
+ /** Reflects that {@link #shutdown()} was explicitly called. */
+ boolean isShutdown();
Review Comment:
done
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/WindmillStream.java:
##########
@@ -32,15 +33,37 @@
/** Superclass for streams returned by streaming Windmill methods. */
@ThreadSafe
public interface WindmillStream {
+
+ /** An identifier for the backend worker where the stream is
sending/receiving RPCs. */
+ String backendWorkerToken();
+
/** Indicates that no more requests will be sent. */
- void close();
+ void halfClose();
/** Waits for the server to close its end of the connection, with timeout. */
boolean awaitTermination(int time, TimeUnit unit) throws
InterruptedException;
/** Returns when the stream was opened. */
Instant startTime();
+ /**
+ * Shutdown the stream. There should be no further interactions with the
stream once this has been
+ * called.
+ */
+ void shutdown();
+
+ /** Reflects that {@link #shutdown()} was explicitly called. */
+ boolean isShutdown();
+
+ Type streamType();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
