m-trieu commented on code in PR #31784:
URL: https://github.com/apache/beam/pull/31784#discussion_r1691599705
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/sideinput/SideInputStateFetcher.java:
##########
@@ -64,13 +62,6 @@ public class SideInputStateFetcher {
private final Function<GlobalDataRequest, GlobalData> fetchGlobalDataFn;
private long bytesRead = 0L;
- public SideInputStateFetcher(
- Function<GlobalDataRequest, GlobalData> fetchGlobalDataFn,
- DataflowStreamingPipelineOptions options) {
- this(fetchGlobalDataFn, SideInputCache.create(options));
- }
-
- @VisibleForTesting
SideInputStateFetcher(
Review Comment:
the class reference is public, but creation is package private
added internal annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
