kennknowles commented on code in PR #32134:
URL: https://github.com/apache/beam/pull/32134#discussion_r1715837089
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1730,8 +1730,6 @@ public PCollection<KafkaRecord<K, V>> expand(PBegin
input) {
.withKeyDeserializerProvider(kafkaRead.getKeyDeserializerProvider())
.withValueDeserializerProvider(kafkaRead.getValueDeserializerProvider())
.withManualWatermarkEstimator()
- .withRedistribute()
Review Comment:
If a user launches a pipeline with 2.58 and then upgrades to the fixed 2.59
while passing `--updateCompatibilityVersion=2.58.0` then we have no ability to
give them a correct pipeline (changing allow/disallow duplicates flag is not
update compatible either). So I don't think that it is worth preserving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
