scwhittle commented on code in PR #32134:
URL: https://github.com/apache/beam/pull/32134#discussion_r1718283327
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1730,8 +1730,6 @@ public PCollection<KafkaRecord<K, V>> expand(PBegin
input) {
.withKeyDeserializerProvider(kafkaRead.getKeyDeserializerProvider())
.withValueDeserializerProvider(kafkaRead.getValueDeserializerProvider())
.withManualWatermarkEstimator()
- .withRedistribute()
Review Comment:
Whether or not the performance changes seems orthogonal to respecting the
user configuration and defaulting to not introducing duplicates. But it likely
depends on the pipeline and what would be fused into reading Kafka if
redistribute is better or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
