sjvanrossum commented on code in PR #32060:
URL: https://github.com/apache/beam/pull/32060#discussion_r1751465230
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionService.java:
##########
@@ -39,34 +43,43 @@
* <p>This class provides a way to connect to a Solace broker and receive
messages from a queue. The
* connection is established using basic authentication.
*/
-public class BasicAuthJcsmpSessionService extends SessionService {
- private final String queueName;
- private final String host;
- private final String username;
- private final String password;
- private final String vpnName;
+@AutoValue
+public abstract class BasicAuthJcsmpSessionService extends SessionService {
Review Comment:
Beam's AutoValue classes generally use get/set prefixes, is there a reason
to not follow the general style here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
