iht commented on code in PR #32060:
URL: https://github.com/apache/beam/pull/32060#discussion_r1755198289
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionServiceFactory.java:
##########
@@ -65,11 +64,15 @@ public abstract static class Builder {
@Override
public SessionService create() {
- return new BasicAuthJcsmpSessionService(
- checkStateNotNull(queue, "SolaceIO.Read: Queue is not set.").getName(),
- host(),
- username(),
- password(),
- vpnName());
+ BasicAuthJcsmpSessionService.Builder builder =
BasicAuthJcsmpSessionService.builder();
+ if (queue != null) {
+ builder = builder.queueName(queue.getName());
+ }
Review Comment:
This class was initially used for the `Read` connector alone, which requires
that `queue` property to be set, and should fail if it is not set.
The `Write` connector does not need a pre-existing `queue`. I changed the
`queueName` parameter to `@Nullable` and this to a check since now the
`queueName` value is optional.
Initially, there were different classes for `SessionService`-ish for both
connectors, with different properties. Now we use a single class, for
consistency across the `Read` and `Write` connectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
