m-trieu commented on code in PR #31902:
URL: https://github.com/apache/beam/pull/31902#discussion_r1757343712
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/budget/EvenGetWorkBudgetDistributor.java:
##########
@@ -67,17 +70,18 @@ public <T extends GetWorkBudgetSpender> void
distributeBudget(
GetWorkBudgetSpender getWorkBudgetSpender =
streamAndDesiredBudget.getKey();
GetWorkBudget desired = streamAndDesiredBudget.getValue();
GetWorkBudget remaining = getWorkBudgetSpender.remainingBudget();
- if (isBelowFiftyPercentOfTarget(remaining, desired)) {
+ if (isBelowFiftyPercentOfTarget(remaining, desired) &&
isActiveWorkBudgetAware) {
Review Comment:
whether its overriding or additive is depending on the internal
implementation of `GetWorkBudgetSpender.adjustBudget()`
based on the current implementation that this is reflecting, we do not
account for remaining budget here it is handled internally in adjustBudget.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
