m-trieu commented on code in PR #31902: URL: https://github.com/apache/beam/pull/31902#discussion_r1757370614
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/AbstractWindmillStream.java: ########## @@ -82,13 +86,14 @@ public abstract class AbstractWindmillStream<RequestT, ResponseT> implements Win private final CountDownLatch finishLatch; private final Set<AbstractWindmillStream<?, ?>> streamRegistry; private final int logEveryNStreamFailures; - private final Supplier<StreamObserver<RequestT>> requestObserverSupplier; - // Indicates if the current stream in requestObserver is closed by calling close() method - private final AtomicBoolean streamClosed; private final String backendWorkerToken; - private @Nullable StreamObserver<RequestT> requestObserver; + private final ResettableRequestObserver<RequestT> requestObserver; + private final AtomicBoolean isShutdown; + private final AtomicBoolean streamClosed; Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
